Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix npm scripts on windows #242

Merged
merged 1 commit into from
Aug 4, 2024
Merged

build: fix npm scripts on windows #242

merged 1 commit into from
Aug 4, 2024

Conversation

RebeccaStevens
Copy link
Collaborator

fix #241

@RebeccaStevens
Copy link
Collaborator Author

window's doesn't seem to like single quotes

@vitaly-t
Copy link
Owner

vitaly-t commented Aug 4, 2024

Awesome, that does it! 👍

vitaly-t
vitaly-t approved these changes Aug 4, 2024
View reviewed changes
Copy link
Owner

@vitaly-t vitaly-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@RebeccaStevens RebeccaStevens merged commit 52fb2b4 into main Aug 4, 2024
8 checks passed
@RebeccaStevens RebeccaStevens deleted the windows-fix branch August 4, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitaly-t vitaly-t vitaly-t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests error on Windows
2 participants
@RebeccaStevens @vitaly-t