Move icu dependency to PystykorvaLib

- The CLI nor tests need it
visuve · Apr 14, 2024 · e720d73 · e720d73
1 parent 6926b2e
commit e720d73
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/.github/workflows/ubuntu.yml b/.github/workflows/ubuntu.yml
@@ -25,16 +25,16 @@ jobs:
         cmake -G Ninja -DCMAKE_C_COMPILER=/usr/bin/gcc-12 -DCMAKE_CXX_COMPILER=/usr/bin/g++-12 ../..
         ninja
 
-    - name: Test GCC
-      run: valgrind --leak-check=yes ./out/gcc/pystykorva_tests
-
     - name: Build Clang
       run: |
         mkdir -p out/clang
         cd out/clang
         cmake -G -DCMAKE_C_COMPILER=/usr/bin/clang-15 -DCMAKE_CXX_COMPILER=/usr/bin/clang++-15 ../..
         ninja
 
+    - name: Test GCC
+      run: valgrind --leak-check=yes ./out/gcc/pystykorva_tests
+
     - name: Test Clang
       run: valgrind --leak-check=yes ./out/clang/pystykorva_tests
 
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -14,11 +14,6 @@ if(MSVC)
 	add_compile_options(/MP /W4 /WX)
 endif()
 
-# apt install libicu-dev / dnf install icu
-find_package(ICU COMPONENTS i18n uc REQUIRED)
-
-message(${ICU_INCLUDE_DIR})
-
 add_subdirectory("PystykorvaLib")
 include_directories("PystykorvaLib")
 

diff --git a/PystykorvaLib/CMakeLists.txt b/PystykorvaLib/CMakeLists.txt
@@ -1,3 +1,8 @@
+# apt install libicu-dev / dnf install icu
+find_package(ICU COMPONENTS i18n uc REQUIRED)
+
+message(${ICU_INCLUDE_DIR})
+
 file(GLOB SourceFiles "*.cpp")
 
 if(CMAKE_SYSTEM_NAME MATCHES "Windows")