Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup code and add old action code #49

Merged
merged 5 commits into from
Sep 14, 2024
Merged

Cleanup code and add old action code #49

merged 5 commits into from
Sep 14, 2024

Conversation

johlju
Copy link
Member

@johlju johlju commented Sep 14, 2024

This change is Reviewable

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.98%. Comparing base (7f19e45) to head (278f0bf).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/runOld.ts 87.75% 5 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   93.24%   90.98%   -2.26%     
==========================================
  Files           5        5              
  Lines          74      122      +48     
  Branches       12       24      +12     
==========================================
+ Hits           69      111      +42     
- Misses          5       10       +5     
- Partials        0        1       +1     
Flag Coverage Δ
unittests 90.98% <88.88%> (-2.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/wait.ts 100.00% <100.00%> (ø)
src/runOld.ts 87.75% <87.75%> (ø)

@johlju johlju merged commit f71e400 into main Sep 14, 2024
7 checks passed
@johlju johlju deleted the fix/cleanup-code branch September 14, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant