Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command Invoke-PesterJob #8

Merged
merged 17 commits into from
Sep 2, 2024
Merged

Conversation

johlju
Copy link
Member

@johlju johlju commented Sep 1, 2024

Pull Request (PR) description

  • Public commands:
    • Invoke-PesterJob
    • Get-ModuleVersion
    • ConvertTo-RelativePath

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Documentation added/updated in README.md and source/WikiSource.
  • Comment-based help added/updated for all new/changed functions.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where applicable). See
    DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

source/Public/ConvertTo-RelativePath.ps1 Fixed Show fixed Hide fixed
source/Public/Invoke-PesterJob.ps1 Fixed Show fixed Hide fixed
source/Public/Invoke-PesterJob.ps1 Fixed Show fixed Hide fixed
source/Public/Invoke-PesterJob.ps1 Fixed Show fixed Hide fixed
source/Public/Invoke-PesterJob.ps1 Fixed Show fixed Hide fixed
source/Public/Invoke-PesterJob.ps1 Fixed Show fixed Hide fixed
source/Public/Invoke-PesterJob.ps1 Fixed Show fixed Hide fixed
source/Public/Invoke-PesterJob.ps1 Fixed Show fixed Hide fixed
source/Public/Invoke-PesterJob.ps1 Fixed Show fixed Hide fixed
source/Public/Invoke-PesterJob.ps1 Fixed Show fixed Hide fixed
Copy link

codecov bot commented Sep 1, 2024

Codecov Report

Attention: Patch coverage is 66.92913% with 42 lines in your changes missing coverage. Please review.

Project coverage is 81%. Comparing base (b654967) to head (b451032).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
source/Public/Invoke-PesterJob.ps1 60% 42 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main    #8    +/-   ##
===================================
- Coverage    98%   81%   -18%     
===================================
  Files         9    15     +6     
  Lines       215   417   +202     
===================================
+ Hits        212   339   +127     
- Misses        3    78    +75     
Flag Coverage Δ
unit 81% <66%> (-18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
source/Public/ConvertTo-RelativePath.ps1 100% <100%> (ø)
source/Public/Get-ModuleVersion.ps1 100% <100%> (ø)
source/Public/Invoke-PesterJob.ps1 60% <60%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 5 files at r1, 1 of 3 files at r2, 7 of 7 files at r3, all commit messages.
Reviewable status: all files reviewed, 13 unresolved discussions (waiting on @Github-advanced-security[bot])


source/Public/ConvertTo-RelativePath.ps1 line 35 at r1 (raw file):

Previously, github-advanced-security[bot] wrote…

Unable to determine parameter set used by example 1 for the function ConvertTo-RelativePath

Show more details

Done.


source/Public/Invoke-PesterJob.ps1 line 136 at r1 (raw file):

Previously, github-advanced-security[bot] wrote…

A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block

Show more details

Done.


source/Public/Invoke-PesterJob.ps1 line 137 at r1 (raw file):

Previously, github-advanced-security[bot] wrote…

A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block

Show more details

Done.


source/Public/Invoke-PesterJob.ps1 line 138 at r1 (raw file):

Previously, github-advanced-security[bot] wrote…

A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block

Show more details

Done.


source/Public/Invoke-PesterJob.ps1 line 139 at r1 (raw file):

Previously, github-advanced-security[bot] wrote…

A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block

Show more details

Done.


source/Public/Invoke-PesterJob.ps1 line 140 at r1 (raw file):

Previously, github-advanced-security[bot] wrote…

A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block

Show more details

Done.


source/Public/Invoke-PesterJob.ps1 line 198 at r1 (raw file):

Previously, github-advanced-security[bot] wrote…

A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block

Show more details

Done.


source/Public/Invoke-PesterJob.ps1 line 199 at r1 (raw file):

Previously, github-advanced-security[bot] wrote…

A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block

Show more details

Done.


source/Public/Invoke-PesterJob.ps1 line 200 at r1 (raw file):

Previously, github-advanced-security[bot] wrote…

A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block

Show more details

Done.


source/Public/Invoke-PesterJob.ps1 line 201 at r1 (raw file):

Previously, github-advanced-security[bot] wrote…

A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block

Show more details

Done.


source/Public/Invoke-PesterJob.ps1 line 202 at r1 (raw file):

Previously, github-advanced-security[bot] wrote…

A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block

Show more details

Done.


source/Public/Invoke-PesterJob.ps1 line 313 at r1 (raw file):

Previously, github-advanced-security[bot] wrote…

Write-Error is used to create a terminating error. throw or $pscmdlet.ThrowTerminatingError should be used.

Show more details

Done.


source/Public/Invoke-PesterJob.ps1 line 295 at r2 (raw file):

Previously, github-advanced-security[bot] wrote…

Hashtable is not correctly formatted. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-hashtables-or-objects

Show more details

Done.

@johlju johlju merged commit 8178f7c into viscalyx:main Sep 2, 2024
11 of 13 checks passed
@johlju johlju deleted the f/add-invoke-pesterjob branch September 2, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant