Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with parameters getting empty string #11

Merged
merged 4 commits into from
Feb 3, 2024

Conversation

johlju
Copy link
Member

@johlju johlju commented Feb 3, 2024

Pull Request (PR) description

  • Fix bootstrap script parameter block.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

Copy link

codecov bot commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cce3388) 93% compared to head (7c38d51) 93%.
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@        Coverage Diff         @@
##           main   #11   +/-   ##
==================================
  Coverage    93%   93%           
==================================
  Files         2     2           
  Lines        86    87    +1     
==================================
+ Hits         80    81    +1     
  Misses        6     6           
Flag Coverage Δ
unit 93% <100%> (+<1%) ⬆️
Files Coverage Δ
source/Public/Start-PSResourceGetBootstrap.ps1 96% <100%> (+<1%) ⬆️

@johlju johlju merged commit 9943005 into viscalyx:main Feb 3, 2024
22 of 24 checks passed
@johlju johlju deleted the fix/issue-10 branch February 3, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running iwr bit.ly/psresourceget | iex throws an exception
1 participant