Change AssignPublicIPv4Address default value to true #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiaxin Shan <[email protected]>
|
/cc @cpuguy83 |
|
Not sure I understand why this one is a good default. ACI also does public subnets... its nice for quick and easy demos but other than that I don't see the benefit. |
|
I think it makes sense to use private subnets in Prod environment. I am fine to leave it to private and I can add more docs then, otherwise it's kind of tricky and people may think this is not working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jiaxin Shan [email protected]
Resolve #13
Make
AssignPublicIPv4Addressdefault totruehelps user run through their demo.