feat(fs-gen): implement initramfs building and archiving #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BioTheWolff <[email protected]>
Signed-off-by: BioTheWolff <[email protected]>
Signed-off-by: BioTheWolff <[email protected]>
Signed-off-by: BioTheWolff <[email protected]>
Signed-off-by: BioTheWolff <[email protected]>
Signed-off-by: BioTheWolff <[email protected]>
Signed-off-by: BioTheWolff <[email protected]>
Signed-off-by: BioTheWolff <[email protected]>
Signed-off-by: BioTheWolff <[email protected]>
…og messages Signed-off-by: BioTheWolff <[email protected]>
Signed-off-by: BioTheWolff <[email protected]>
Signed-off-by: BioTheWolff <[email protected]>
Signed-off-by: BioTheWolff <[email protected]>
Signed-off-by: BioTheWolff <[email protected]>
Signed-off-by: BioTheWolff <[email protected]>
Signed-off-by: BioTheWolff <[email protected]>
Signed-off-by: BioTheWolff <[email protected]>
BioTheWolff
force-pushed
the
pr/initramfs
branch
from
e7cb2e8 to
6a4c87d
Compare
Signed-off-by: BioTheWolff <[email protected]>
Signed-off-by: Mathias-Boulay <[email protected]>
Signed-off-by: Mathias-Boulay <[email protected]>
Signed-off-by: Mathias-Boulay <[email protected]>
|
|
||
| // So, for any of you who may be scared, this is the regex from the OCI Distribution Sepcification for the image name + the tag | ||
| static RE_IMAGE_NAME: Lazy<Regex> = Lazy::new(|| { | ||
| Regex::new(r"[a-z0-9]+((\.|_|__|-+)[a-z0-9]+)*(\/[a-z0-9]+((\.|_|__|-+)[a-z0-9]+)*)*:[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127}").unwrap() |
There was a problem hiding this comment.
This regex pattern expects an image name in the form image:tag and not just . But our function that downloads layers doesn't have a problem with receiving an image name without tag (it will just use 'latest' as tag by default). Maybe we should change the regex to make tag part optional?
[a-z0-9]+((\.|_|__|-+)[a-z0-9]+)*(\/[a-z0-9]+((\.|_|__|-+)[a-z0-9]+)*)*(?::[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127})?
There was a problem hiding this comment.
I could do that for a later iteration, sure
Mathias-Boulay
approved these changes
Apr 22, 2024
sea-gull-diana
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to implement a stable "v0" for initramfs building.
This is done in three steps:
initfile, then build the CPIO bundle and archive itNote: as of now,
fs-gendoes not insert and implement the agent.Note: only images from Docker hub can be downloaded, a later version will implement adding a repository prefix
Example of a command: