-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(virtio): Adding Virtio-net Support to Cloudlet #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assstra
reviewed
Apr 22, 2024
Assstra
reviewed
Apr 22, 2024
- MMIO Device Discovery by the kernel command line - irq allocator Signed-off-by: sylvain-pierrot <[email protected]>
Signed-off-by: sylvain-pierrot <[email protected]>
Signed-off-by: sylvain-pierrot <[email protected]>
Signed-off-by: sylvain-pierrot <[email protected]>
Signed-off-by: sylvain-pierrot <[email protected]>
Signed-off-by: sylvain-pierrot <[email protected]>
Signed-off-by: sylvain-pierrot <[email protected]>
Kuruyia
requested changes
Apr 29, 2024
Signed-off-by: sylvain-pierrot <[email protected]>
Kuruyia
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work!
sylvain-pierrot
added a commit
to sylvain-pierrot/cloudlet
that referenced
this pull request
Apr 30, 2024
* feat(virtio): configure net device - MMIO Device Discovery by the kernel command line - irq allocator Signed-off-by: sylvain-pierrot <[email protected]> * feat: add simple handler Signed-off-by: sylvain-pierrot <[email protected]> * refactor code architecture about devices + add queue/handlers Signed-off-by: sylvain-pierrot <[email protected]> * chore: fix traits for generic + refactor code Signed-off-by: sylvain-pierrot <[email protected]> * feat: add working device Signed-off-by: sylvain-pierrot <[email protected]> * refactor: remove all unwrap Signed-off-by: sylvain-pierrot <[email protected]> * fix: cargo clippy Signed-off-by: sylvain-pierrot <[email protected]> * refactor: remove unnecessary comments Signed-off-by: sylvain-pierrot <[email protected]> --------- Signed-off-by: sylvain-pierrot <[email protected]>
sylvain-pierrot
added a commit
that referenced
this pull request
Apr 30, 2024
* feat(virtio): Adding Virtio-net Support to Cloudlet (#22) * feat(virtio): configure net device - MMIO Device Discovery by the kernel command line - irq allocator Signed-off-by: sylvain-pierrot <[email protected]> * feat: add simple handler Signed-off-by: sylvain-pierrot <[email protected]> * refactor code architecture about devices + add queue/handlers Signed-off-by: sylvain-pierrot <[email protected]> * chore: fix traits for generic + refactor code Signed-off-by: sylvain-pierrot <[email protected]> * feat: add working device Signed-off-by: sylvain-pierrot <[email protected]> * refactor: remove all unwrap Signed-off-by: sylvain-pierrot <[email protected]> * fix: cargo clippy Signed-off-by: sylvain-pierrot <[email protected]> * refactor: remove unnecessary comments Signed-off-by: sylvain-pierrot <[email protected]> --------- Signed-off-by: sylvain-pierrot <[email protected]> * feat: configure guest iface address + rename vmm cli args for better understanding Signed-off-by: sylvain-pierrot <[email protected]> * Feat/grpc streams (#31) * feat: streaming and pty setup --------- Signed-off-by: Mauran <[email protected]> Signed-off-by: sylvain-pierrot <[email protected]> --------- Signed-off-by: sylvain-pierrot <[email protected]> Signed-off-by: Mauran <[email protected]> Co-authored-by: Thomas Mauran <[email protected]>
remi-espie
pushed a commit
to remi-espie/cloudlet
that referenced
this pull request
May 1, 2024
* feat(virtio): Adding Virtio-net Support to Cloudlet (virt-do#22) * feat(virtio): configure net device - MMIO Device Discovery by the kernel command line - irq allocator Signed-off-by: sylvain-pierrot <[email protected]> * feat: add simple handler Signed-off-by: sylvain-pierrot <[email protected]> * refactor code architecture about devices + add queue/handlers Signed-off-by: sylvain-pierrot <[email protected]> * chore: fix traits for generic + refactor code Signed-off-by: sylvain-pierrot <[email protected]> * feat: add working device Signed-off-by: sylvain-pierrot <[email protected]> * refactor: remove all unwrap Signed-off-by: sylvain-pierrot <[email protected]> * fix: cargo clippy Signed-off-by: sylvain-pierrot <[email protected]> * refactor: remove unnecessary comments Signed-off-by: sylvain-pierrot <[email protected]> --------- Signed-off-by: sylvain-pierrot <[email protected]> * feat: configure guest iface address + rename vmm cli args for better understanding Signed-off-by: sylvain-pierrot <[email protected]> * Feat/grpc streams (virt-do#31) * feat: streaming and pty setup --------- Signed-off-by: Mauran <[email protected]> Signed-off-by: sylvain-pierrot <[email protected]> --------- Signed-off-by: sylvain-pierrot <[email protected]> Signed-off-by: Mauran <[email protected]> Co-authored-by: Thomas Mauran <[email protected]> Signed-off-by: ESPIE <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Virtio-net Support to Cloudlet
Description:
This Pull Request aims to enhance the functionality of Cloudlet by adding support for virtio-net, a paravirtualized network device.
Changes Introduced (checklist):
Virtio Over MMIO:
VMMIO
from doc.Related Issues:
#3