feat(vmm): exit the VMM on kbd reset #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when killing the `init` process, the VMM hangs because it is unable to handle the kernel trying to reboot the machine. On an x86 PC platform, it is possible to reset the CPU by [sending byte `0xFE` to the keyboard controller command register](https://wiki.osdev.org/%228042%22_PS/2_Controller#CPU_Reset). This is actually part of the emergency reboot procedure of [the Linux kernel](https://elixir.bootlin.com/linux/v6.8.2/source/arch/x86/kernel/reboot.c#L627). This adds a bit of code to handle such a write operation by exiting the VMM process. Signed-off-by: Kuruyia <[email protected]>
Kuruyia
requested review from
Hunh0w,
charley04310,
MurielParaire and
thomas-mauran
Kuruyia
requested review from
a team
and removed request for
Hunh0w,
charley04310,
MurielParaire and
thomas-mauran
thomas-mauran
approved these changes
Apr 1, 2024
sea-gull-diana
referenced
this pull request
in Mathias-Boulay/cloudlet
Apr 13, 2024
Currently, when killing the `init` process, the VMM hangs because it is unable to handle the kernel trying to reboot the machine. On an x86 PC platform, it is possible to reset the CPU by [sending byte `0xFE` to the keyboard controller command register](https://wiki.osdev.org/%228042%22_PS/2_Controller#CPU_Reset). This is actually part of the emergency reboot procedure of [the Linux kernel](https://elixir.bootlin.com/linux/v6.8.2/source/arch/x86/kernel/reboot.c#L627). This adds a bit of code to handle such a write operation by exiting the VMM process. Signed-off-by: Kuruyia <[email protected]>
sea-gull-diana
referenced
this pull request
in Mathias-Boulay/cloudlet
Apr 15, 2024
Currently, when killing the `init` process, the VMM hangs because it is unable to handle the kernel trying to reboot the machine. On an x86 PC platform, it is possible to reset the CPU by [sending byte `0xFE` to the keyboard controller command register](https://wiki.osdev.org/%228042%22_PS/2_Controller#CPU_Reset). This is actually part of the emergency reboot procedure of [the Linux kernel](https://elixir.bootlin.com/linux/v6.8.2/source/arch/x86/kernel/reboot.c#L627). This adds a bit of code to handle such a write operation by exiting the VMM process. Signed-off-by: Kuruyia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently, when killing the
initprocess, the VMM hangs because it is unable to handle the kernel trying to reboot the machine.On an x86 PC platform, it is possible to reset the CPU by sending byte
0xFEto the keyboard controller command register. This is actually part of the emergency reboot procedure of the Linux kernel.This adds a bit of code to handle such a write operation by exiting the VMM process.