Skip to content

Commit

Permalink
fix coverage?
Browse files Browse the repository at this point in the history
  • Loading branch information
virgesmith committed Oct 21, 2024
1 parent 4a87293 commit 7721332
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ jobs:
python-version: [ "3.12" ]
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- name: "pip: Python ${{ matrix.python-version }} coverage"
uses: actions/setup-python@v5
with:
Expand Down
2 changes: 1 addition & 1 deletion codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ coverage:
threshold: 1% # leeway
patch:
default:
target: 80%
target: 75%
4 changes: 3 additions & 1 deletion src/Error.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#include "Error.h"
#include <pybind11/pybind11.h>

namespace py = pybind11;

const char* no::NotImplementedError::what() const noexcept
{
return m_msg.c_str();
Expand All @@ -16,6 +18,6 @@ void no::exception_translator(std::exception_ptr p)
}
catch (const no::NotImplementedError& e)
{
PyErr_SetString(PyExc_NotImplementedError, e.what());
py::set_error(PyExc_NotImplementedError, e.what());

Check warning on line 21 in src/Error.cpp

View check run for this annotation

Codecov / codecov/patch

src/Error.cpp#L21

Added line #L21 was not covered by tests
}
}

0 comments on commit 7721332

Please sign in to comment.