Better support MSVC .libs by using NULL char terminators when detected #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSVC likes to use NULL character terminators instead of
newlines (\n) for their listing, which causes parsing to not
work correctly, usually with this error:
arpy.ArchiveFormatError: file references a name not present in the index
This is fixed by detecting NULL character usage and
using that delimiter accordingly.
Some very helpful inspiration that led to figuring this out:
* https://www.winehq.org/pipermail/wine-patches/2013-April/123863.html (winedump/lib.c)
* https://substrate.dev/rustdocs/latest/object/pe/
* http://hmelnov.icc.ru/geos/scripts/WWWBinV.dll/ShowR?COFF_LIB.rfi
* http://www.textfiles.com/programming/FORMATS/lib.txt
* https://www.ntcore.com/files/richsign.htm
* http://bytepointer.com/resources/pietrek_lib_file_format.htm
|
Kudos, SonarCloud Quality Gate passed!
|
|
Could you send some minimal file for tests as well, please? |
|
nvm, found one in the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSVC likes to use NULL character terminators instead of
newlines (\n) for their listing, which causes parsing to not
work correctly, usually with this error:
This is fixed by detecting NULL character usage and
using that delimiter accordingly.
Addresses: #16
Some very helpful inspiration that led to figuring this out: