Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: better name for isPermittedGlobalShareArtifact #4

Conversation

pieterlukasse
Copy link

@pieterlukasse pieterlukasse commented May 24, 2024

Fixes the following issue:

⚠️ after more review, I decided to NOT include uc-cdis@b8fa939 (the isOwner() change) because this will require changes in WebAPI which are related to "team projects", so that would delay this PR from merging upstream.

@pieterlukasse pieterlukasse changed the title Fix/owner check and remove dead code Fix/remove dead code May 24, 2024
@pieterlukasse pieterlukasse force-pushed the fix/owner_check_and_remove_dead_code branch from 73040e2 to 0d75edd Compare May 24, 2024 18:33
...previous name isPermittedGlobalShareCohort did not reflect the
fact that it is about all kind of artifacts
@pieterlukasse pieterlukasse force-pushed the fix/owner_check_and_remove_dead_code branch from 0d75edd to 4872345 Compare September 2, 2024 19:26
@pieterlukasse pieterlukasse changed the title Fix/remove dead code Fix: better name for isPermittedGlobalShareArtifact Sep 2, 2024
@rkboyce rkboyce merged commit 01eca8c into vinci-ohdsi:feature/global-sharing Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants