Follow renames #62
Merged
Follow renames #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keeps build time stats accross renames. See #60. This commit is an MVP, lacking tests and optimizations. Even then, parsing 80 update files takes 2-6ms on my system, so the cost of this double-parsing single-threaded implementation is already low. We get the list of update files from the mtimedb, which is nice because we already parse it and can yet again avoid locating the installed repos, but also lists (on my system) some non-existing files and files from an inactive repo.
A bit of a brain-teaser to find and cleanly document failure modes, but it found one bug (duplicates overwriting instead of being ignored), which gives some confidence in the test.
Interestingly, parsing the mtimedb json takes 3x as long as parsing 65 update files.
vincentdephily
force-pushed
the
follow_renames
branch
from
09b9931 to
db0606e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.