Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the icon boxes issue ! #471 #555

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Fixed the icon boxes issue ! #471 #555

merged 1 commit into from
Oct 11, 2024

Conversation

Subhajit-2023-44
Copy link
Contributor

Hello PR,
Fixed issue number - #471

Untitled.video.-.Made.with.Clipchamp.6.mp4
Untitled.video.-.Made.with.Clipchamp.7.mp4
Untitled.video.-.Made.with.Clipchamp.8.mp4

& I also fixed this issue in "Team" page !
Issue -

Untitled.video.-.Made.with.Clipchamp.5.mp4

Issue Fixed !

Untitled.video.-.Made.with.Clipchamp.9.mp4

@mansiruhil13

Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bobble-ai-rcmb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 11:41am

Copy link

👋 Thank you for opening this pull request! We're excited to review your contribution. Please give us a moment, and we'll get back to you shortly!

Feel free to join our community on Discord to discuss more!

@Subhajit-2023-44
Copy link
Contributor Author

@mansiruhil13

@vimistify vimistify merged commit 36c7390 into vimistify:main Oct 11, 2024
4 checks passed
Copy link

🚀 Thank you for your contribution! This pull request has been closed. If you have any questions or need further assistance, feel free to reach out.

Copy link
Collaborator

@MastanSayyad MastanSayyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSS changes, reducing to level 1 as you are top Contributor

@Subhajit-2023-44

@Subhajit-2023-44
Copy link
Contributor Author

CSS changes, reducing to level 1 as you are top Contributor

@Subhajit-2023-44

@MastanSayyad ok sir🙏🏻 I don't deserve level 3 for this😔, you and another project manager🙏🏻 remove some of my levels🤧 ok..

Untitled.video.-.Made.with.Clipchamp.95.mp4

but sir can you kindly give me level 3 for this? He gave me just level 1, Is that correct? 😭

Please🥺, I would be very grateful if you could give me level 3 for this..

Thank You 🙏🏻

Copy link
Collaborator

@MastanSayyad MastanSayyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Subhajit-2023-44 These are minimal changes,

image

Here you have just entered one extra line and added align-content: center; justify-items: stretch; justify-content: center; align-items: stretch

image

And here too, here you added one extra line above and one below while the changes are none, except adjusting overflow-x with none from hidden

image

Here are no changes only added gap: 22px from 20px which is minimal change

image

you are rank 12 and a top contrinbutor, these changes will not justify level 3

image

@MastanSayyad
Copy link
Collaborator

CSS changes, reducing to level 1 as you are top Contributor
@Subhajit-2023-44

@MastanSayyad ok sir🙏🏻 I don't deserve level 3 for this😔, you and another project manager🙏🏻 remove some of my levels🤧 ok..

Untitled.video.-.Made.with.Clipchamp.95.mp4
but sir can you kindly give me level 3 for this? He gave me just level 1, Is that correct? 😭

Please🥺, I would be very grateful if you could give me level 3 for this..

Thank You 🙏🏻

Sure @Subhajit-2023-44 send me the PR link, I'll review it and add level 3, thank you!

@Subhajit-2023-44
Copy link
Contributor Author

Hi @Subhajit-2023-44 These are minimal changes,

image

Here you have just entered one extra line and added align-content: center; justify-items: stretch; justify-content: center; align-items: stretch

image

And here too, here you added one extra line above and one below while the changes are none, except adjusting overflow-x with none from hidden

image

Here are no changes only added gap: 22px from 20px which is minimal change

image

you are rank 12 and a top contrinbutor, these changes will not justify level 3

image

Yes sir I totally agree with you.. 🙏🏻

Screenshot 2024-10-27 133104

@Subhajit-2023-44
Copy link
Contributor Author

CSS changes, reducing to level 1 as you are top Contributor
@Subhajit-2023-44

@MastanSayyad ok sir🙏🏻 I don't deserve level 3 for this😔, you and another project manager🙏🏻 remove some of my levels🤧 ok..
Untitled.video.-.Made.with.Clipchamp.95.mp4
but sir can you kindly give me level 3 for this? He gave me just level 1, Is that correct? 😭
Please🥺, I would be very grateful if you could give me level 3 for this..
Thank You 🙏🏻

Sure @Subhajit-2023-44 send me the PR link, I'll review it and add level 3, thank you!

@MastanSayyad okay sir,

link - iamrahulmahato/master-web-development#1501 (comment)

@MastanSayyad
Copy link
Collaborator

@Subhajit-2023-44 done ✅

@Subhajit-2023-44
Copy link
Contributor Author

@Subhajit-2023-44 done ✅

Thank You sir 🙏🏻🙏🏻

@Subhajit-2023-44
Copy link
Contributor Author

@MastanSayyad Sir🙏🏻 kindly review these 5 PR and add level 3, I think I deserve level 3 because I have added new features✨ in all of them but they didn't give me level 3 and also didn't give any reply.. 😭😭

Sir please 🙏🏻, I would be very grateful if you could give me level 3... 🥺

He gave me just level 1 😭

iamrahulmahato/master-web-development#1786 (comment)

iamrahulmahato/master-web-development#1842 (comment)

iamrahulmahato/master-web-development#1953 (comment)

He gave me level 2 🙁

vishanurag/Canvas-Editor#1070 (comment)

vishanurag/Canvas-Editor#1011 (comment)

Thank you

@Subhajit-2023-44
Copy link
Contributor Author

@MastanSayyad
Copy link
Collaborator

@Subhajit-2023-44 updated the levels and please dont ask for level 3 for such changes, it can only have level 2

@Subhajit-2023-44
Copy link
Contributor Author

@Subhajit-2023-44 updated the levels and please dont ask for level 3 for such changes, it can only have level 2

Thank you sir🙏🏻 for giving at least level 2 (he gave me just level 1😭)

Okay sir 🙏🏻

@Subhajit-2023-44
Copy link
Contributor Author

Subhajit-2023-44 commented Nov 9, 2024

@Subhajit-2023-44 updated the levels and please dont ask for level 3 for such changes, it can only have level 2

Sorry to bother you again 🙏🏻😞

@MastanSayyad sir can I deserve level 3 for this? I added a new feature profile page..

Screenshot 2024-11-09 154238
Screenshot 2024-11-09 154255

I would be very grateful if you could give me level 3 for these.. I really in trouble after extending 10 days.. 😞📉

@Subhajit-2023-44
Copy link
Contributor Author

@MastanSayyad sir 🙏🏻

@MastanSayyad
Copy link
Collaborator

@Subhajit-2023-44 already added + some PRs are similar so for that I cant give level 3

@Subhajit-2023-44
Copy link
Contributor Author

@Subhajit-2023-44 already added + some PRs are similar so for that I cant give level 3

@MastanSayyad Thanks a lot sir, 🙏🏻🥰

Sir please merge this PR -

ankit071105/Ticket-Booking#1081 (comment)

@Subhajit-2023-44
Copy link
Contributor Author

Thank you sir @MastanSayyad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants