This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Update textColor on button for over and active states only if provide… #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d a custom color chore(baseline): update lost-pixel baselines (#368)
juliewongbandue
force-pushed
the
a11y-button-hover-active-text
branch
from
c798c67
to
84befb6
Compare
tylerthegrove
approved these changes
Sep 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Updates text color on buttons for hover and active states only if provided a custom color.
Screenshots & Recordings
Screen.Recording.2023-09-28.at.12.58.39.PM.mov
How it does that
Testing
Storybook