Issue 379: TypeError: Cannot read properties of undefined (reading 'trim') #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zshall is attempting to deploy a commit to the Vidstack Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
What is the current behavior?
Vime's HLS provider throws an error when attempting to load on the latest version of HLS.js in Safari:
TypeError: Cannot read properties of undefined (reading 'trim')This appears to be related to how HLS generates an object URL (
blob:) and thus thesourceelement fails the HLS file extension and content-type tests when this happens.What is the new behavior?
Added a cache for storing the last known good HLS source URL and if one exists when the
sourceisn't able to be found we return that one.Does this introduce a breaking change?
Other information
I had to pin the version of
@types/nodeto what it was because the newest version is causing TypeScript build errors, hence the lock file changes.I've put screenshots and reasoning into the issue and tested with Svelte on Safari and Chrome. Let me know if anything needs to change!
#379 (comment)
#379 (comment)