Enhanced ImageをラップしたImage.svelteを作る #320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
まず、enhanced:imgをアプデ |
ryoppippi
force-pushed
the
feature/Image.svelte
branch
from
8df5e3c to
e93b614
Compare
Deploying vim-jp-radio-lp with
|
| Latest commit: |
d4431e2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://400a6b89.lp-d1f.pages.dev |
| Branch Preview URL: | https://feature-image-svelte.lp-d1f.pages.dev |
|
svelte自身をアプデ。エラーが消えることを確認 |
ryoppippi
force-pushed
the
feature/Image.svelte
branch
from
687e483 to
b25e5c4
Compare
|
enhanced:imgをラップしたImage.svelteを作成 |
|
各々のcomponentでImage.svelteを使用するよう変更 |
これが最新のsvelteで発生してるので一旦様子見 |
|
#321 |
ryoppippi
force-pushed
the
feature/Image.svelte
branch
from
725935a to
d4431e2
Compare
|
rebaseしてforce pushしてしまったので、やり直しな機運 |
|
svelte/enhanced-img/sveltekitのアプデは別ぶらんちでやって良さそうなのでそっちに移動する |
|
一旦closeしてPRし直す |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ryoppippi.comの実装において、enhanced:imgをラップしたコンポーネントを用いると取り回しが良かったので採用する