This repository has been archived by the owner on Oct 24, 2018. It is now read-only.
Fix the wrong displayname/avatar change messages (maybe) #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vijfhoek
suggested changes
Nov 1, 2017
| msg = '> {} changed their display name to {}'\ | ||
| .format(oldname, displayname) | ||
| print("DEBUG: {}".format(event)) | ||
| if ('unsigned' in event and 'prev_content' in event['unsigned']) or 'prev_content' in event: |
There was a problem hiding this comment.
You seem to be checking for the same thing multiple times, mind rewriting this if statement to be a bit more efficient?
|
I just noticed that this didn't fix the bug after all, it still did the thing when I changed my avatar |
|
For some reason when changing my avatar, it sends an "joined the room" message even though it should recognize that the previous state was already "join". |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR might fix #42 (not sure if I fixed the logic that caused it, but I fixed something, at least).