Skip to content
This repository has been archived by the owner on Oct 24, 2018. It is now read-only.

Display name and avatar changes are considered "x has joined the room" #42

Open
turt2live opened this issue Oct 20, 2017 · 3 comments
Open

Display name and avatar changes are considered "x has joined the room" #42

turt2live opened this issue Oct 20, 2017 · 3 comments
Labels
bug priority/high
Milestone
Beta release

Comments

@turt2live
Copy link

No description provided.

@vijfhoek
Copy link
Owner

Probably related to #34

@vijfhoek vijfhoek added this to the Beta release milestone Oct 23, 2017
@vurpo
Copy link
Contributor

vurpo commented Oct 26, 2017

Is there currently any code that checks for the difference between the current and previous m.room.membership state event whenever such an event is received? I haven't checked, but without comparing the current and previous state event (the replaces field in the event), room joins, displayname changes, and avatar changes are indistinguishable.

@turt2live
Copy link
Author

There's some code, but it appears to not be working
https://github.com/SijmenSchoon/telematrix/blob/master/telematrix/__init__.py#L295-L302

@vurpo vurpo mentioned this issue Oct 30, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug priority/high
Projects
None yet
Milestone
Beta release
Development

Successfully merging a pull request may close this issue.

Fix the wrong displayname/avatar change messages (maybe) vurpo/telematrix
3 participants
@vijfhoek @turt2live @vurpo