Add support for NIF unload and upgrade #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+96
to
+97
| _priv_data: *mut *mut rustler::codegen_runtime::c_void, | ||
| _old_priv_data: *mut *mut rustler::codegen_runtime::c_void, |
There was a problem hiding this comment.
It doesn't make a whole lot of sense to not pass priv data into the provided upgrade function. But... load doesn't either so maybe it's fine?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds is a newer version of rusterlium#281 as 281 is now very old and has conflicts.
Furthermore, this makes each of
load,unloadandupgradeand optional parameter to theinit!macro, primarily because it's possible for a stub nif to exist without specifying any of those.One of the primary reasons why
unloadandupgradeare required is because newer versions of OTP and EQC (Quviq's quickcheck) insist on having the NIF support (at least in stub form) that there is anunloadandupgrademechanism provided by the library otherwise the quickcheck wouldn't run.