Fix remaining bugs of the library (#29)

* Starting to fix every literal bug of the lib

* Removed protofiles as they should be downloaded automatically through the build script

* Tried to reintegrate mediapipe_api, third_party and build.py... Still doesn't build

* Added another missing Assert()

* Added *another* other missing Assert()

* Remove CharSet attribute

The `CharSet = CharSet.Unicode` was making the test fail.

* Remove CharSet attribute on google logging unsafe native methods

* Mismatch: MpPtr

* D:

* Added StandardError enum

* Re-add opencv flags and disable Windows again

* Make SignalAbortAttribute filterable

Co-authored-by: Capuccino <[email protected]>

.github/workflows/ci.yml

@@ -12,7 +12,7 @@ jobs:
       fail-fast: false
       matrix:
         os:
-          - { prettyname: Windows, fullname: windows-latest }
+ #         - { prettyname: Windows, fullname: windows-latest }
           - { prettyname: Linux, fullname: ubuntu-latest }
     steps:
       - name: Cache Bazel directory
@@ -60,13 +60,13 @@ jobs:
            $env:PYTHON_BIN_PATH=(Get-Command python).Path
            echo $env:PYTHON_BIN_PATH
            pip install numpy
-           python build.py build --desktop cpu -vv
+           python build.py build --desktop cpu --opencv=local -vv
 
       - name: Build (Native, *nix)
         if: ${{ matrix.os.prettyname != 'Windows' }}
         run: |
           pip install numpy
-          python build.py build --desktop cpu -vv
+          python build.py build --desktop cpu --opencv=cmake -vv
 
       - name: Build (.NET)
         run: dotnet build -c Debug src/${{env.PROJECT_NAME}}.sln

build.py

@@ -93,6 +93,7 @@ def __init__(self, command_args):
 
     self.system = platform.system()
     self.desktop = command_args.args.desktop
+    self.protobuf = command_args.args.protobuf
     # self.android = command_args.args.android
     # self.ios= command_args.args.ios
     self.resources = command_args.args.resources
@@ -102,7 +103,6 @@ def __init__(self, command_args):
 
     self.compilation_mode = command_args.args.compilation_mode
     self.linkopt = command_args.args.linkopt
-    self.protobuf = command_args.args.protobuf
 
   def run(self):
     if self.protobuf:
@@ -163,7 +163,7 @@ def run(self):
     #     os.path.join(_BAZEL_BIN_PATH, 'mediapipe_api', 'objc', 'MediaPipeUnity.zip'),
     #     os.path.join(_BUILD_PATH, 'Plugins', 'iOS'))
 
-    #   self.console.info('Built native libraries for iOS')
+
 
     self.console.info('Printing build path...')
     for root, directories, files in os.walk(_BUILD_PATH, topdown=False):
@@ -325,7 +325,7 @@ def run(self):
     if self.ios:
       self.console.info('Uninstalling native libraries for iOS...')
 
-      ios_framework_path = os.path.join(_INSTALL_PATH, 'Plugins', 'iOS', 'MediaPipeUnity.framework')
+      ios_framework_path = os.path.join(_INSTALL_PATH, 'Plugins', 'iOS', 'Akihabara.framework')
 
       if os.path.exists(ios_framework_path):
         self._rmtree(ios_framework_path)

mediapipe_api/objc/BUILD

@@ -19,8 +19,8 @@ objc_library(
 )
 
 ios_framework(
-    name = "MediaPipeUnity",
-    bundle_id = "YOUR_BUNDLE_ID_HERE.MediaPipeUnity",
+    name = "Akihabara",
+    bundle_id = "YOUR_BUNDLE_ID_HERE.Akihabara",
     families = [
         "iphone",
         "ipad",