Skip to content

Commit

Permalink
Merge pull request #4 from views-platform/feature_001_refactor_managers
Browse files Browse the repository at this point in the history
Change ModelPath to ModelPathManager
  • Loading branch information
smellycloud authored Dec 12, 2024
2 parents 5c585d9 + 5593217 commit ef64f34
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 39 deletions.
34 changes: 0 additions & 34 deletions .github/workflows/run_pytest.yml

This file was deleted.

5 changes: 2 additions & 3 deletions views_stepshifter/manager/stepshifter_manager.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
from views_pipeline_core.managers.model_manager import ModelManager
from views_pipeline_core.managers.path_manager import ModelPath
from views_pipeline_core.managers.model import ModelPathManager, ModelManager
from views_pipeline_core.models.outputs import generate_output_dict
from views_pipeline_core.files.utils import read_log_file, create_log_file, read_dataframe
from views_pipeline_core.wandb.utils import add_wandb_monthly_metrics, generate_wandb_log_dict, log_wandb_log_dict
Expand All @@ -22,7 +21,7 @@

class StepshifterManager(ModelManager):

def __init__(self, model_path: ModelPath) -> None:
def __init__(self, model_path: ModelPathManager) -> None:
super().__init__(model_path)
self._is_hurdle = self._config_meta["algorithm"] == "HurdleModel"

Expand Down
2 changes: 1 addition & 1 deletion views_stepshifter/models/hurdle_model.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from views_pipeline_core.managers.model_manager import ModelManager
from views_pipeline_core.managers.model import ModelManager
from views_stepshifter.models.stepshifter import StepshifterModel
from views_stepshifter.models.validation import views_validate
from sklearn.utils.validation import check_is_fitted
Expand Down
2 changes: 1 addition & 1 deletion views_stepshifter/models/stepshifter.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from typing import List, Dict
# from views_forecasts.extensions import *
from views_stepshifter.models.validation import views_validate
from views_pipeline_core.managers.model_manager import ModelManager
from views_pipeline_core.managers.model import ModelManager

logger = logging.getLogger(__name__)

Expand Down

0 comments on commit ef64f34

Please sign in to comment.