Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code to use new Three API #293

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

KasperQd
Copy link

@KasperQd KasperQd commented Jan 6, 2025

Description

Updates the code to use the new Three API. The old code used a deprecated API, which caused none of the projections but '360' to work.

This PR solves issues: #256, #268 and #266

Specific Changes proposed

  • interact directly with uv attribute of geometry.
  • remove conversion to BufferGeometry, since the geometry is already a child of BufferGeometry.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Unit Tests updated or fixed (not needed here)
    • Docs/guides updated (not needed here)
  • Reviewed by Two Core Contributors

Copy link

@bbsimong bbsimong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a maintainer, but would like to see this merged.

There are similar changes in the WebXR PR (https://github.com/videojs/videojs-vr/pull/273/files#diff-598b75d6dc772eb13aa7141f35bb93046ae26c58a97e8647ecf7f74aec8ae93fR156). Unfortunately, it looks like that PR may be abandoned? I'm planning to open up a PR with our fork, but it will be rather large. Any smaller PRs that make our fork PR smaller would be very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants