Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update VHS to 3.14.0, and its dependencies #8839

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

mister-ben
Copy link
Contributor

Description

Updates VHS and dependencies. These updates include experimental ManagedMediaSource support, and support for #EXT-X-DEFINE, #EXT-X-I-FRAMES-ONLY and #EXT-X-I-FRAME-STREAM-INF in m3u8-parser.

Specific Changes proposed

  • @videojs/http-streaming ^3.14.0
  • @videojs/vhs-utils ^4.1.1
  • aes-decrypter ^4.0.2
  • m3u8-parser ^7.2.0

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
    • Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab)
    • Has no changes to JSDoc which cause npm run docs:api to error
  • Reviewed by Two Core Contributors

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.83%. Comparing base (73db132) to head (16acb72).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8839      +/-   ##
==========================================
+ Coverage   83.18%   83.83%   +0.64%     
==========================================
  Files         120      120              
  Lines        8047     8047              
  Branches     1931     1931              
==========================================
+ Hits         6694     6746      +52     
+ Misses       1353     1301      -52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mister-ben mister-ben added the needs: LGTM Needs one or more additional approvals label Aug 23, 2024
Copy link
Contributor

@adrums86 adrums86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@adrums86
Copy link
Contributor

adrums86 commented Sep 9, 2024

Going to merge this, however I'm going to bump VHS to 3.14.1 in a separate PR because they're a VTT timing fix in there that should make it out in the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: LGTM Needs one or more additional approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants