Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow captions in devices that use old chrome to be shown #8826

Merged
merged 15 commits into from
Aug 26, 2024

fix: add condition for position of textTrackDisplay in STV devices

870de98
Select commit
Loading
Failed to load commit list.
Merged

fix: allow captions in devices that use old chrome to be shown #8826

fix: add condition for position of textTrackDisplay in STV devices
870de98
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 20, 2024 in 0s

84.29% (+1.17%) compared to 57c27f8

View this Pull Request on Codecov

84.29% (+1.17%) compared to 57c27f8

Details

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.29%. Comparing base (57c27f8) to head (870de98).
Report is 5 commits behind head on main.

Files Patch % Lines
src/js/tracks/text-track-display.js 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8826      +/-   ##
==========================================
+ Coverage   83.12%   84.29%   +1.17%     
==========================================
  Files         120      120              
  Lines        8052     9378    +1326     
  Branches     1931     2378     +447     
==========================================
+ Hits         6693     7905    +1212     
- Misses       1359     1473     +114     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.