Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(volume): vertical slider causes viewport overflow in rtl layout #8320

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −7
Open

fix(volume): vertical slider causes viewport overflow in rtl layout #8320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/css/components/_volume.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,11 @@
position: relative;

&.vjs-volume-vertical {
left: -3.5em;
height: 8em;
width: 3em;

pointer-events: initial;

@include transition(left 0s);
}
$transition-property: visibility 0.1s, opacity 0.1s, height 0.1s, width 0.1s, left 0s, top 0s;
Expand All @@ -75,10 +79,6 @@
}

.video-js .vjs-volume-panel .vjs-volume-control.vjs-volume-vertical {
height: 8em;
width: 3em;
left: -3000em;

$transition-property: visibility 1s, opacity 1s, height 1s 1s, width 1s 1s, left 1s 1s, top 1s 1s;
@include transition($transition-property)
}
Expand Down Expand Up @@ -192,10 +192,11 @@
}

.video-js .vjs-volume-vertical {
width: 3em;
height: 8em;
left: -3.5em;
bottom: 8em;

pointer-events: none;

@include background-color-with-alpha($primary-background-color, $primary-background-transparency);
}

Expand Down