Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a player option keepTimeTooltipInSeekBar to prevent time tooltip overflow #7913

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Merge branch 'videojs:main' into main

65750e3
Select commit
Loading
Failed to load commit list.
Open

Add a player option keepTimeTooltipInSeekBar to prevent time tooltip overflow #7913

Merge branch 'videojs:main' into main
65750e3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 5, 2024 in 0s

80.83% (-0.11%) compared to 4e2f8ad

View this Pull Request on Codecov

80.83% (-0.11%) compared to 4e2f8ad

Details

Codecov Report

Attention: Patch coverage is 36.36364% with 14 lines in your changes missing coverage. Please review.

Project coverage is 80.83%. Comparing base (4e2f8ad) to head (65750e3).
Report is 304 commits behind head on main.

Files with missing lines Patch % Lines
...rc/js/control-bar/progress-control/time-tooltip.js 36.36% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7913      +/-   ##
==========================================
- Coverage   80.94%   80.83%   -0.11%     
==========================================
  Files         116      116              
  Lines        7467     7479      +12     
  Branches     1816     1821       +5     
==========================================
+ Hits         6044     6046       +2     
- Misses       1423     1433      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.