Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time tooltip out of bounds on the right #8273

Closed
phloxic opened this issue May 13, 2023 · 1 comment
Closed

time tooltip out of bounds on the right #8273

phloxic opened this issue May 13, 2023 · 1 comment
Labels
needs: triage This issue needs to be reviewed

Comments

@phloxic
Copy link
Contributor

phloxic commented May 13, 2023

Description

Since c4c8fc1 progress time tooltip and mouse display time tooltip can move out of bounds on the right side of the player.

A fix was proposed in #7308. However, it was declined because it broke the fixes done by the above commit.

However, the alignment issues pointed out in #7308 (comment) cannot be reproduced with the current Video.js v8.x and v7.x versions after the patch is applied:

Note that I can reproduce the misalignment when I apply the patch to v7.9.4 (the reason why the patch was declined at the time).

Reduced test case

https://phloxic.productions/test/videojs/ttt/v8.html

Steps to reproduce

  1. Set up player with a wide time tooltip
  2. Observe behaviour when the time tooltip is in its rightmost position

Errors

No errors.

What version of Video.js are you using?

v8.3.0, v7.21.4 -- introduced in 7.9.4

Video.js plugins used.

none

What browser(s) including version(s) does this occur with?

all

What OS(es) and version(s) does this occur with?

all

@phloxic
Copy link
Contributor Author

phloxic commented Sep 28, 2024

Since 50f14bd the time tooltip does not out of bounds of the control bar by default.
Closing.

@phloxic phloxic closed this as completed Sep 28, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: triage This issue needs to be reviewed
Projects
None yet
Development

No branches or pull requests

1 participant