Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time tooltip out of bounds on the right of player #49

Closed
phloxic opened this issue May 12, 2023 · 3 comments
Closed

time tooltip out of bounds on the right of player #49

phloxic opened this issue May 12, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@phloxic
Copy link
Owner

phloxic commented May 12, 2023

Since Video.js version 7.9.4 the time tooltips can go out of bounds on the right side of the player.

See e.g. videojs/video.js#7248 and not accepted fix videojs/video.js#7308 et.al.

This affects the plugin because it hijacks the tooltip in the mouse time display to display the preview thumbnails. Especially with widescreen movies and/or few/none buttons/menus to the right of the progressbar, the thumbnail might go (partially) out of bounds on the right side.

A nasty emergency fix would be to set overflow: hidden on the player container.

@phloxic phloxic added the bug Something isn't working label May 12, 2023
@phloxic phloxic self-assigned this May 12, 2023
@phloxic
Copy link
Owner Author

phloxic commented May 13, 2023

See: See videojs/video.js#8273

@phloxic
Copy link
Owner Author

phloxic commented May 13, 2023

imho, for the time being applying this small change to a recent version of Video.js (either v7.x or v8.x) solves the problem without the side-effects which were the reason the patch was declined at the time.

@phloxic
Copy link
Owner Author

phloxic commented Sep 28, 2024

Since videojs/video.js@50f14bd the time tooltip does not out of bounds of the control bar by default.
Closing.

@phloxic phloxic closed this as not planned Won't fix, can't repro, duplicate, stale Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant