Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in Batch #587

Merged
merged 6 commits into from
Nov 24, 2023
Merged

Fix bugs in Batch #587

merged 6 commits into from
Nov 24, 2023

Conversation

viceroypenguin
Copy link
Owner

@viceroypenguin viceroypenguin commented Nov 24, 2023

This PR fixes three bugs in the Batch operator and adds tests to verify the fixes.

Bugs:

  • The size parameter of the buffered implementation should be allowed to be equal to array.Length.
  • BatchListIterator should return the right Count when supplied an empty sequence.
  • The buffered implementation returned the wrong value for an empty source sequence.

@viceroypenguin viceroypenguin added this to the 5.4.0 milestone Nov 24, 2023
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (13d70fc) 93.02% compared to head (9e1ffda) 93.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #587      +/-   ##
==========================================
+ Coverage   93.02%   93.03%   +0.01%     
==========================================
  Files         255      255              
  Lines        8140     8140              
  Branches     1618     1620       +2     
==========================================
+ Hits         7572     7573       +1     
+ Misses        359      358       -1     
  Partials      209      209              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viceroypenguin viceroypenguin merged commit f75040c into master Nov 24, 2023
3 checks passed
@viceroypenguin viceroypenguin deleted the batch branch November 24, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant