Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firecracker snapshot upf ctriface #928

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Firecracker snapshot upf ctriface #928

wants to merge 21 commits into from

Conversation

char-1ee
Copy link
Contributor

@char-1ee char-1ee commented Feb 1, 2024

This is an informal PR for debugging. Please DO NOT merge.

  1. These updates are based on my firecracker-snapshot-upf-test branch: https://github.com/char-1ee/vHive/tree/firecracker-snapshot-upf-test.
  2. These updates currently cannot pass integration tests in ./vhive_test.go
  3. I committed the updates that can pass ./ctriface/iface_test.go, which contains the TestStartSnapStop() from failing_test.go.

@char-1ee
Copy link
Contributor Author

char-1ee commented Feb 1, 2024

@ustiugov

ustiugov
ustiugov reviewed Feb 2, 2024
View reviewed changes
Copy link
Member

@ustiugov ustiugov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most importantly, please fix the naming

ctriface/iface.go Show resolved Hide resolved
ctriface/iface.go Outdated Show resolved Hide resolved
ctriface/iface.go Outdated Show resolved Hide resolved
ctriface/iface.go Show resolved Hide resolved
ctriface/iface.go Show resolved Hide resolved
ctriface/manual_cleanup_test.go Outdated Show resolved Hide resolved
ctriface/orch.go Outdated Show resolved Hide resolved
cri/firecracker/coordinator.go Outdated Show resolved Hide resolved
@char-1ee
Refactor
58a7040 
Signed-off-by: char-1ee <[email protected]>
@char-1ee
Refactor the uffd socket path
1082679 
Signed-off-by: char-1ee <[email protected]>
ustiugov
ustiugov reviewed Feb 5, 2024
View reviewed changes
ctriface/manual_cleanup_test.go Outdated Show resolved Hide resolved
ctriface/manual_cleanup_test.go Outdated Show resolved Hide resolved
ctriface/manual_cleanup_test.go Outdated Show resolved Hide resolved
ctriface/orch.go Outdated Show resolved Hide resolved
@char-1ee char-1ee force-pushed the firecracker-snapshot-upf-ctriface branch from 1324e37 to e8092e4 Compare February 28, 2024 15:31
@char-1ee char-1ee force-pushed the firecracker-snapshot-upf-ctriface branch from d3c914e to f294880 Compare March 15, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ustiugov ustiugov ustiugov left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@char-1ee @ustiugov @BenjaminChun