Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update knative version to 1.9 #662

Closed

Conversation

anshalshukla
Copy link
Contributor

Summary

Regular Update. Updated the knative version.

@ustiugov ustiugov changed the title Update kn version Update knative version to 1.9 Jan 31, 2023
@ustiugov
Copy link
Member

@anshalshukla have you tested it with the workflow from the quickstart guide (with Firecracker and with containers)? Once you are done with testing, please ask @shyamjesal for a review.

@ustiugov
Copy link
Member

I noticed that the wiki page by Shyam doesn't really say about which repo and branch of serving one needs to take. @shyamjesal, could you please clarify this on the wiki page?

One needs to copy and rebase the following branch in our fork of Knative: ease-lab/serving#8

@shyamjesal
Copy link
Collaborator

shyamjesal commented Jan 31, 2023

Yes, that branch is correct, we need to update that branch and add the generated yamls. Wiki updated.

@ustiugov
Copy link
Member

ustiugov commented Feb 1, 2023

@anshalshukla please follow the updated wiki

@anshalshukla
Copy link
Contributor Author

Sure, I'll do it today

@anshalshukla
Copy link
Contributor Author

@shyamjesal I've updated the PR with the suggested branch and have also tested the workflows from quickstart guide.

@ustiugov
Copy link
Member

ustiugov commented Feb 3, 2023

@shyamjesal wait a bit. Anshal needs to rebase the copied branch first.

@ustiugov
Copy link
Member

ustiugov commented Feb 7, 2023

@anshalshukla any updates on this PR?

@anshalshukla
Copy link
Contributor Author

anshalshukla commented Feb 7, 2023

Updated knative using this branch. Tested the workflows and it works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants