Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set cxx version to 17 if Kokkos is found #817

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Set cxx version to 17 if Kokkos is found #817

merged 1 commit into from
Apr 13, 2024

Conversation

Dsantra92
Copy link
Contributor

@Dsantra92 Dsantra92 commented Mar 10, 2024 •
edited
Loading

fix #798

@vgvassilev
Copy link
Owner

Can you improve the commit message?

@codecov Codecov
Copy link

codecov bot commented Mar 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.89%. Comparing base (e930a4a) to head (ec85e4b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #817   +/-   ##
=======================================
  Coverage   94.89%   94.89%           
=======================================
  Files          49       49           
  Lines        7478     7478           
=======================================
  Hits         7096     7096           
  Misses        382      382

@Dsantra92 Dsantra92 changed the title FIxed cxx version for unittests if KOKKOS is found Set cxx version to 17 if Kokkos is found Mar 10, 2024
@Dsantra92
Copy link
Contributor Author

Can you improve the commit message?

Sorry for the oversight, hope it okay now.

@vgvassilev
Copy link
Owner

Can you improve the commit message?

Sorry for the oversight, hope it okay now.

No worries. Were you able to reproduce the failure locally and confirm that's the right fix for it?

@vgvassilev
Copy link
Owner

The commit message should include Fixes #798 on a new line.

@vgvassilev
Copy link
Owner

The commit message should include Fixes #798 on a new line.

@Dsantra92, ping.

@vgvassilev
Copy link
Owner

Looks like that'd help with #826.

vgvassilev
vgvassilev approved these changes Apr 13, 2024
View reviewed changes
Copy link
Owner

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay. LGTM!

@vgvassilev vgvassilev merged commit c3202c1 into vgvassilev:master Apr 13, 2024
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgvassilev vgvassilev vgvassilev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Dsantra92 @vgvassilev