[cmake] Improve the cmake infrastructure. #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure for to add the right dependency in cases clad is built against the monorepo.
vgvassilev
force-pushed
the
cmake-improvements
branch
from
a73b705
to
8189ea3
Compare
This patch continues to improve the builds of Clad in the context of the llvm mono repo. It tries to reuse as much infrastructure as possible between the packaged version of llvm and in-tree builds. This is why we have dropped the CLANG_ variable as they are not available in the in-tree builds. We have a good replacement as we always require LLVM and Clang to be in sync and this is the way they are distributed anyway.
vgvassilev
force-pushed
the
cmake-improvements
branch
from
8189ea3
to
6227657
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1159 +/- ##
=======================================
Coverage 94.56% 94.56%
=======================================
Files 51 51
Lines 8944 8944
=======================================
Hits 8458 8458
Misses 486 486 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch continues to improve the builds of Clad in the context of the llvm mono repo. It tries to reuse as much infrastructure as possible between the packaged version of llvm and in-tree builds. This is why we have dropped the CLANG_ variable as they are not available in the in-tree builds. We have a good replacement as we always require LLVM and Clang to be in sync and this is the way they are distributed anyway.