Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffs scientist bio suits against slimes #37222

Open
wants to merge 6 commits into
base: Bleeding-Edge
Choose a base branch
from

Conversation

SECBATON-GRIFFON
Copy link
Contributor

@SECBATON-GRIFFON SECBATON-GRIFFON commented Oct 2, 2024

[balance][qol][tweak]

What this does

something requested by @DeityLink, makes scientist biosuits do moderate protection from melee (ie slime) attacks and also block half of the power of them feeding on you

Why it's good

less of a hassle when slime raising goes wrong

How it was tested

posess slime, attack and feed player, go back to player

Changelog

🆑

  • tweak: Scientist biosuits now offer some protection from slime attacks and slime feeding. (half reduction for the latter)
  • spellcheck: Messages from slime feeding sent to the slime and feedee are now formatted better.
  • spellcheck: Biosuit descriptions now spell "contaminant" properly.

@D3athrow-Issues D3athrow-Issues added Balance Potentially going to upset people as it changes balance of the game. Tweak I changed the thermostat from 70 degrees to 69 degrees. ❤️ Quality of Life ❤️ This is a change that removes hassle and improves quality of life. labels Oct 2, 2024
@SECBATON-GRIFFON SECBATON-GRIFFON marked this pull request as ready for review October 2, 2024 18:29
@Dacendeth
Copy link
Contributor

Dacendeth commented Oct 2, 2024

Feels like just checking for 100 bio coverage on all parts would be less snowflaky, also your current check doesnt care if they have the related helmet on or not.

@SECBATON-GRIFFON
Copy link
Contributor Author

Feels like just checking for 100 bio coverage on all parts would be less snowflaky, also your current check doesnt care if they have the related helmet on or not.

i mean slimes don't really feed on that area do they? will add it if you think its necessary though, easy one line fix

@jwhitak
Copy link
Collaborator

jwhitak commented Oct 2, 2024

This is too strong of a buff - it nearly completely eliminates the risk of xenobio! Other methods of getting immunity come with severe downsides (sliming oneself being the main example). Might as well port the tg style monitor remote management system.

I'd be fine with a tweak level of buff, but complete immunity is a no.

@SECBATON-GRIFFON
Copy link
Contributor Author

This is too strong of a buff - it nearly completely eliminates the risk of xenobio! Other methods of getting immunity come with severe downsides (sliming oneself being the main example). Might as well port the tg style monitor remote management system.

I'd be fine with a tweak level of buff, but complete immunity is a no.

complete immunity has now been removed, feeding damage has been halved instead

@angryturnip
Copy link
Contributor

I think the risk of being killed by your slimes is part of the job and shouldn't be mitigated by a roundstart item. I'd rather something like this be gated behind being an advanced bio suit in the trader item pool or from using a slime core from a slime type that's at the end of one of the lines on a biosuit.

@angryturnip
Copy link
Contributor

That being said, I started writing that comment before seeing the change you made above. Still iffy on it though, but with the change I no longer think it'd need to be locked behind any other content

@jwhitak
Copy link
Collaborator

jwhitak commented Oct 2, 2024

I'm still iffy on it... I'm actually willing to merge this if people like it now though.

I do like an upgrade to give immunity. This seems to be a really good chance to add a slime suit upgrade for the biosuit using the new slime_act system. Good for a future PR.

@DeityLink
Copy link
Collaborator

Yeah I didn't suggest that they offer total protection, but if only that they at least delay slime dealing you clone damage. Since it's annoying to heal it should give you time to shove them off.

@RealestEstate
Copy link
Contributor

Remember to wear proper PPE

@west3436 west3436 requested a review from jwhitak October 8, 2024 15:58
code/modules/clothing/suits/bio.dm Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Potentially going to upset people as it changes balance of the game. ❤️ Quality of Life ❤️ This is a change that removes hassle and improves quality of life. Tweak I changed the thermostat from 70 degrees to 69 degrees.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants