Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create BuildBuddy gRPC client #310

Merged
merged 22 commits into from
Jun 5, 2023
Merged

Conversation

mvgijssel
Copy link
Member

@mvgijssel mvgijssel commented Jun 1, 2023

ref #275

TODO:

  • Call from GitHub actions
  • Print logs nicely
  • Call proper workflow (instead of test everything)

@mvgijssel mvgijssel changed the title try client Create BuildBuddy gRPC client Jun 1, 2023
@mvgijssel
Copy link
Member Author

Using trick from here bazelbuild/rules_docker#2149 (comment) to make the rules_docker and rules_proto_grpc play nice.

@mvgijssel
Copy link
Member Author

Use https://grpc.io/docs/languages/python/basics/ to properly instantiate the client

@mvgijssel
Copy link
Member Author

mvgijssel commented Jun 1, 2023

Install and require the grpcio library as mentioned here https://grpc.io/docs/languages/python/quickstart/ to get the “google.rpc” package? Or maybe ”protobuf” package?

@mvgijssel mvgijssel marked this pull request as draft June 1, 2023 17:13
@mvgijssel
Copy link
Member Author

https://gist.github.com/luc-lynx/6d0fbf16c587bafeffeb15a34186d320 To make it work with authentication?

@mvgijssel
Copy link
Member Author

Calling the script can use Bazel run —config buildbuddy_rbe … inside of GitHub? To speed up execution?

@mvgijssel mvgijssel marked this pull request as ready for review June 5, 2023 18:10
@mvgijssel mvgijssel merged commit 09c289f into master Jun 5, 2023
@mvgijssel mvgijssel deleted the mg/275/protobuf-client-take-two branch June 5, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant