Add option to handle absent cross_az_attach #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noonedeadpunk
force-pushed
the
bugfix/cross_az_attach
branch
from
706147c to
9ffda17
Compare
|
Ok, now I see how it's wrong... As eventually you might have only 1 AZ in cinder while have multiple in Nova, which will break the behavior who has cross-az attach :( |
noonedeadpunk
force-pushed
the
bugfix/cross_az_attach
branch
from
9ffda17 to
135d280
Compare
noonedeadpunk
changed the title
|
I'd say there should be a follow-up patch to add smth like |
noonedeadpunk
force-pushed
the
bugfix/cross_az_attach
branch
from
135d280 to
04da372
Compare
At the moment volumes for workers are gonna be spawn in a default AZ completely disregarding user request for Availability Zone. In a design where cross_az_attach is disabled, an attempt to add a volume to worker has high failure percentage due to fallback to the default scheduling zone, unless allow_availability_zone_fallback is disabled. This patch adds a configuration option `cross_az_attach` which is set to True by default to align with Nova typical behavior. It will define AZ to be set to `nova` according to a CSI default [1]. When `cross_az_attach` is set to False, AZ for the volume will be set to the cluster AZ value. This ensures that volume will be created in a same zone as workers are preventing failures. [1] https://github.com/kubernetes/cloud-provider-openstack/blob/d228854cf58e7b4ed93d5e7ba68ab639450e3449/docs/cinder-csi-plugin/using-cinder-csi-plugin.md#supported-parameters Relates-to: vexxhost#366
noonedeadpunk
force-pushed
the
bugfix/cross_az_attach
branch
from
04da372 to
5c40b60
Compare
|
recheck |
1 similar comment
|
recheck |
|
@mnaser @okozachenko1203 it would be really nice to get some input on this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment volumes for workers are gonna be spawn in a default
AZ completely disregarding user request for Availability Zone.
In a design where cross_az_attach is disabled, an attempt
to add a volume to worker has high failure percentage due to fallback
to the default scheduling zone, unless allow_availability_zone_fallback
is disabled.
This patch adds a configuration option
cross_az_attachwhich is setto True by default to align with Nova typical behavior. It will define
AZ to be set to
novaaccording to a CSI default [1].When
cross_az_attachis set to False, AZ for the volume will be set tothe cluster AZ value.
This ensures that volume will be created in a same zone as workers are
preventing failures.
[1] https://github.com/kubernetes/cloud-provider-openstack/blob/d228854cf58e7b4ed93d5e7ba68ab639450e3449/docs/cinder-csi-plugin/using-cinder-csi-plugin.md#supported-parameters
Relates-to: #366