Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ATMOSPHERE-606] replace value of dnsmasq_dns_servers to 1.1.1.1 #2184

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

adrianreza
Copy link

The bug was detected when customer env use OVN and they got 10.96.0.20 for nameserves from DHCP Agent. We can unset in on atmosphere/roles/neutron/vars/main.yml at main · vexxhost/atmosphere line 63 or replace that value with public DNS, e.g. 1.1.1.1.

@mnaser mnaser changed the title replace value of dnsmasq_dns_servers to 1.1.1.1 [ATMOSPHERE-606] replace value of dnsmasq_dns_servers to 1.1.1.1 Dec 7, 2024
@@ -60,7 +60,7 @@ __neutron_helm_values:
service_provider: VPN:strongswan:neutron_vpnaas.services.vpn.service_drivers.ipsec.IPsecVPNDriver:default
dhcp_agent:
DEFAULT:
dnsmasq_dns_servers: "{{ neutron_coredns_cluster_ip | default('10.96.0.20') }}"
dnsmasq_dns_servers: "{{ neutron_coredns_cluster_ip | default('1.1.1.1') }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using ML2/OVS, the 10.96.0.20 works just fine, but when using ML2/OVN we need to use 1.1.1.1.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted back for ML2/OVS to 10.96.0.20

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can simply add this:

dnsmasq_dns_servers: "{{ neutron_coredns_cluster_ip | default('1.1.1.1') }}"

Into the OVN section, since that gets merged into the OVN part.

Also, perhaps I think we should add a variable called neutron_default_dns_servers which gets set to 10.96.0.20 if its not using ovn, and by default, do not set it, so the user has to set it if its using ovn.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added dnsmasq_dns_servers to OVN part. And for neutron_default_dns_servers I put it on neutron conf for ML2/OVS part. I'm not sure if it was correct or not. Need your feedback @mnaser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants