add non root ovs-user-id to ovn container image to rebuild #2044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaguangtang
force-pushed
the
ATMOSPHERE-498-ovnkube-sh-resets-all-permissions-in-run-openvswitch-to-root-root-by-default
branch
from
c2c572c to
d4f0e26
Compare
yaguangtang
changed the title
mnaser
requested changes
Oct 29, 2024
There was a problem hiding this comment.
@yaguangtang I think we need to use this instead:
https://github.com/apconole/ovn-kubernetes/blob/master/dist/images/ovnkube.sh#L95-L96
We should add environment variable OVS_USER_ID and set to 42424 with a new image, so we don't need to make a chart change.
It's added to ovn image |
|
recheck |
…cess update ovn-controler script to chown ovs bridge socket files so that libvirt pod can read fix #1982
yaguangtang
force-pushed
the
ATMOSPHERE-498-ovnkube-sh-resets-all-permissions-in-run-openvswitch-to-root-root-by-default
branch
from
d4f0e26 to
c124717
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update ovn-controler script to chown ovs bridge socket files so that libvirt pod can read
fix #1982