Update result_set.go to handle slices/arrays #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Does this PR not cover this feature? |
|
I think that PR covers even more, but it's been stuck for months. If you'd like to merge this minor change go for it, if you can get that PR merged even better |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
I have a query that returns a list of values
The scanRow function did not support scanning slices/arrays, and got me an error "scan: not supported type"
Description:
This PR adds the functionality of scanning arrays/slices to scanRow
How do you solve it?
I extracted most of the switch code to another function "setValue" to get reused while iterating the list values, "setValue" returns an error, it will be called by default, and if an error occurs propagates it
Special notes for your reviewer, ex. impact of this fix, design document, etc: