Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(iam): Add AWS Glue Policy to the IAM Role #1

Merged
merged 1 commit into from
Nov 28, 2024
Merged

feat(iam): Add AWS Glue Policy to the IAM Role #1

merged 1 commit into from
Nov 28, 2024

Conversation

morazow
Copy link
Contributor

@morazow morazow commented Nov 28, 2024

Add AWS Glue policies:

      "glue:GetDatabase",
      "glue:CreateDatabase",
      "glue:GetTable",
      "glue:CreateTable",
      "glue:GetTables"

To the private connections IAM role.

@morazow morazow changed the title Add AWS Glue Policy to the IAM Role feat(iam): Add AWS Glue Policy to the IAM Role Nov 28, 2024
@webertrlz webertrlz self-requested a review November 28, 2024 11:02
@webertrlz
Copy link

thanks @morazow - can you update the commit message to use semantic commit? Suggestion: the same as the PR title.

@morazow morazow force-pushed the vcp-4767-iceberg-glue-policy branch from 452c272 to 3286b7c Compare November 28, 2024 12:11
@morazow
Copy link
Contributor Author

morazow commented Nov 28, 2024

Thanks @webertrlz, done!

@morazow morazow force-pushed the vcp-4767-iceberg-glue-policy branch from 3286b7c to bf6910a Compare November 28, 2024 14:17
@webertrlz
Copy link

Can you do terraform fmt modules/private-connection/iam.tf to fix the failing check?

@morazow morazow force-pushed the vcp-4767-iceberg-glue-policy branch from d9df7da to 5716389 Compare November 28, 2024 15:50
@morazow
Copy link
Contributor Author

morazow commented Nov 28, 2024

Done, thanks @webertrlz

@webertrlz webertrlz merged commit 7752634 into ververica:main Nov 28, 2024
4 checks passed
@github-actions GitHub Actions
Copy link

This PR is included in version 1.1.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webertrlz webertrlz webertrlz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@morazow @webertrlz