Skip to content

Commit

Permalink
[FLINK-35575] Disable PERF_CONTEXT by default in compilation
Browse files Browse the repository at this point in the history
  • Loading branch information
mayuehappy committed Jul 17, 2024
1 parent 9a10201 commit 956b005
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
2 changes: 1 addition & 1 deletion FROCKSDB-RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ To start the crossbuild within a Mac OSX environment:
cp <path-to-ppc64le-musl-lib-so>/librocksdbjni-linux-ppc64le-musl.so java/target/librocksdbjni-linux-ppc64le-musl.so
cp <path-to-arm-lib-so>/librocksdbjni-linux-aarch64.so java/target/librocksdbjni-linux-aarch64.so
cp <path-to-arm-musl-lib-so>/librocksdbjni-linux-aarch64-musl.so java/target/librocksdbjni-linux-aarch64-musl.so
FROCKSDB_VERSION=1.0 PORTABLE=1 ROCKSDB_DISABLE_JEMALLOC=true DEBUG_LEVEL=0 make frocksdbjavastaticreleasedocker
FROCKSDB_VERSION=1.0 PORTABLE=1 ROCKSDB_DISABLE_JEMALLOC=true DEBUG_LEVEL=0 DISABLE_PERF_CONTEXT=1 make frocksdbjavastaticreleasedocker

*Note, we disable jemalloc on mac due to https://github.com/facebook/rocksdb/issues/5787*.

Expand Down
6 changes: 6 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,12 @@ ifndef DISABLE_JEMALLOC
PLATFORM_CCFLAGS += $(JEMALLOC_INCLUDE)
endif

DISABLE_PERF_CONTEXT ?= 0
ifeq ($(DISABLE_PERF_CONTEXT),1)
PLATFORM_CXXFLAGS += -DNPERF_CONTEXT
PLATFORM_CCFLAGS += -DNPERF_CONTEXT
endif

ifndef USE_FOLLY
USE_FOLLY=0
endif
Expand Down

0 comments on commit 956b005

Please sign in to comment.