Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[env] Introduce jni_helper for env_flink #7

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

masteryhx
Copy link
Collaborator

What is the purpose of the change

  • Introduce jni_helper to cache frequently-used jclasses

Brief change log

  • Introduce jni_helper, define cached classes and init them

Verifying this change

This is a tool class improving the jni performance which relys on the Flink environment. So it will be tested when env_flink is ready.

@masteryhx masteryhx requested review from Zakelly, fredia and ljz2051 March 11, 2024 09:04
Copy link
Collaborator

@ljz2051 ljz2051 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I left some comments. PTAL.

CMakeLists.txt Outdated Show resolved Hide resolved
env/flink/jni_helper.cc Show resolved Hide resolved
@masteryhx masteryhx merged commit 4a511b3 into ververica:main Mar 12, 2024
2 checks passed
@masteryhx masteryhx deleted the jni_helper branch March 12, 2024 08:11
fredia pushed a commit to fredia/ForSt that referenced this pull request Sep 26, 2024
Summary:
I must have chosen trimming before frame 8 based on assertion failures, but that trims too many frame for a general segfault. So this changes to start printing at frame 4, as in this example where I've seeded a null deref:

```
Received signal 11 (Segmentation fault)
Invoking LLDB for stack trace...
Process 873208 stopped
* thread ververica#1, name = 'db_stress', stop reason = signal SIGSTOP
    frame #0: 0x00007fb1fe8f1033 libc.so.6`__GI___wait4(pid=873478, stat_loc=0x00007fb1fb114030, options=0, usage=0x0000000000000000) at wait4.c:30:10
  thread ververica#2, name = 'rocksdb:low', stop reason = signal SIGSTOP
    frame #0: 0x00007fb1fe8972a1 libc.so.6`__GI___futex_abstimed_wait_cancelable64 at futex-internal.c:57:12
Executable module set to "/data/users/peterd/rocksdb/db_stress".
Architecture set to: x86_64-unknown-linux-gnu.
True
frame ververica#4: 0x00007fb1fe844540 libc.so.6`__restore_rt at libc_sigaction.c:13
frame ververica#5: 0x0000000000608514 db_stress`rocksdb::StressTest::InitDb(rocksdb::SharedState*) at db_stress_test_base.cc:345:18
frame ververica#6: 0x0000000000585d62 db_stress`rocksdb::RunStressTestImpl(rocksdb::SharedState*) at db_stress_driver.cc:84:17
frame ververica#7: 0x000000000058dd69 db_stress`rocksdb::RunStressTest(shared=0x00006120000001c0) at db_stress_driver.cc:266:34
frame ververica#8: 0x0000000000453b34 db_stress`rocksdb::db_stress_tool(int, char**) at db_stress_tool.cc:370:20
...
```

Pull Request resolved: facebook/rocksdb#12101

Test Plan: manual (see above)

Reviewed By: ajkr

Differential Revision: D51593217

Pulled By: pdillinger

fbshipit-source-id: 4a71eb8e516edbc32e682f9537bc77d073a7b4ed
fredia pushed a commit to fredia/ForSt that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants