Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[env]Introduce flink-env test suite #17

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Conversation

ljz2051
Copy link
Collaborator

@ljz2051 ljz2051 commented Mar 25, 2024

What is the purpose of the change

This pull request introduces a test suite used for UI tests of flink-env interfaces

Brief change log

  • A flink-env test suite
  • Mocked flink filesystem java class

Verifying this change

This change added tests and can be verified by "FlinkEnvTest.java".

Copy link
Collaborator

@masteryhx masteryhx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
PTAL my comments.

/**
* Interface that represents the client side information for a file independent of the file system.
*/
public interface FileStatus {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am thinking maybe we could just let ForSt provide all these classes as a complete jar in the future.
Then some duplicate codes could be avoided.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think we could provide flink-core and forst-statebackend jar packages for ForSt in the future. At present, considering the problem of circular dependency, it needs to be bypassed in the current way.

java/Makefile Show resolved Hide resolved
Copy link
Collaborator

@masteryhx masteryhx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.
LGTM.

@ljz2051 ljz2051 merged commit de9582b into ververica:main Mar 29, 2024
10 checks passed
fredia pushed a commit to fredia/ForSt that referenced this pull request Sep 26, 2024
* [env]Introduce flink-env test suite

(cherry picked from commit de9582b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants