-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[env]Introduce flink-env test suite #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
PTAL my comments.
/** | ||
* Interface that represents the client side information for a file independent of the file system. | ||
*/ | ||
public interface FileStatus { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am thinking maybe we could just let ForSt provide all these classes as a complete jar in the future.
Then some duplicate codes could be avoided.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think we could provide flink-core and forst-statebackend jar packages for ForSt in the future. At present, considering the problem of circular dependency, it needs to be bypassed in the current way.
java/flinktestmock/src/main/java/org/apache/flink/core/fs/FileStatus.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update.
LGTM.
* [env]Introduce flink-env test suite (cherry picked from commit de9582b)
What is the purpose of the change
This pull request introduces a test suite used for UI tests of flink-env interfaces
Brief change log
Verifying this change
This change added tests and can be verified by "FlinkEnvTest.java".