feat(prompt): add prompt support #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So if yes/no variant isn't actually used. Perhaps we could remove it in upstream too. |
wusyong
reviewed
Dec 3, 2024
src/lib.rs
Outdated
| @@ -30,4 +30,4 @@ pub use verso::Verso; | |||
| /// Re-exporting Winit for the sake of convenience. | |||
| pub use winit; | |||
| /// Context | |||
| pub mod context_menu; | |||
| pub mod components; | |||
There was a problem hiding this comment.
We can reuse webivew module I think and move context_menu, panel, and prompt under there.
There was a problem hiding this comment.
renamed to webview and moved WebView Panel into it
|
Verified on macOS. All prompt types seem to work! Screen.Recording.2024-12-04.at.8.53.41.PM.mov |
wusyong
approved these changes
Dec 4, 2024
This was referenced Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
window.alert()window.confirm()andwindow.prompt()supportcontext_menuandpromptunder a components modverso://custom protocol now reads files under a directoryverso://resources/components/prompt/prompt_test.htmlfor testing