Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsigned streaming payload reader with trailers #1045

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

niksis02
Copy link
Contributor

Fixes #1034

Implements an unsigned chunk reader with trailers to handle unsigned chunk encoding efficiently.
The reader is optimized to function correctly with any buffer size provided to the io.Reader.

It also parses and validates the checksum sent at the end of the stream.
All checksum types are supported:

  1. crc32
  2. crc32c
  3. crc64nvme
  4. sha1
  5. sha256

s3api/utils/signed-chunk-reader.go Dismissed Show dismissed Hide dismissed
s3api/utils/unsigned-chunk-reader.go Fixed Show fixed Hide fixed
@niksis02 niksis02 force-pushed the feat/unsigned-streaming-payload-trailer branch from af745e4 to 0b8ad18 Compare January 30, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] - Chunked upload with trailer: default behavior for PutObject/UploadPart since aws version 2.23.0
1 participant