Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit test for mapping packets with lower sequence number than the first mapped packet #1439

Closed
wants to merge 1 commit into from
Closed

add unit test for mapping packets with lower sequence number than the first mapped packet #1439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions worker/test/src/RTC/TestSeqManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1400,4 +1400,19 @@ SCENARIO("SeqManager", "[rtc][SeqMananger]")
SeqManager<uint16_t> seqManager(/*initialOutput*/ 1000);
validate(seqManager, inputs);
}

SECTION("map packets prior to first mapped packet")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fail to see the value that this test adds to the already existing tests? Isn't this already tested in existing tests?

Also, what does "mapped packet" mean? We don't use that terminology anywhere in the source code and in existing tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not covered (or at least not explicitily), does backward wrap-around as a bonus. What terminology do you suggest?

{
// clang-format off
std::vector<TestSeqManagerInput<uint16_t>> inputs =
{
{ 4, 4, false, false },
{ 3, 3, false, false },
{ 65535, 65535, false, false },
};
// clang-format on

SeqManager<uint16_t> seqManager;
validate(seqManager, inputs);
}
}
Loading