Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace support template message with a link #1406

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

nazar-pc
Copy link
Collaborator

@nazar-pc nazar-pc commented Jun 6, 2024

Because people don't read. I think this should be correct, though I don't have a direct preview.

Also someone didn't commit lock file changes last time, so I decided to include it too.

@nazar-pc
Copy link
Collaborator Author

nazar-pc commented Jun 6, 2024

Both Node and Rust tests failed on Windows 🤔

@ibc
Copy link
Member

ibc commented Jun 10, 2024

Both Node and Rust tests failed on Windows 🤔

Crazy. They fail consistently even in Node, which doesn't make sense. Basically all tests that depend on the worker fail.

@ibc
Copy link
Member

ibc commented Jun 10, 2024

Both Node and Rust tests failed on Windows 🤔

Crazy. They fail consistently even in Node, which doesn't make sense. Basically all tests that depend on the worker fail.

Something happens in v3 branch (I've forced CI in branch v3) so this is not something related to this PR. So merging since the problem was already there anyway.

@ibc ibc merged commit f207a5f into versatica:v3 Jun 10, 2024
30 of 35 checks passed
@nazar-pc nazar-pc deleted the replace-support-template-with-link branch June 10, 2024 10:01
@nazar-pc
Copy link
Collaborator Author

Okay, https://mediasoup.org/documentation didn't render as a link, but otherwise it worked!

@ibc
Copy link
Member

ibc commented Jun 10, 2024

Okay, https://mediasoup.org/documentation didn't render as a link, but otherwise it worked!

It's ok because users can just click on the "Open" button.

BTW issues created for those failing tests in Windows CI: #1407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants