Ignore RTP packets with empty payload #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Details - This PR replaces PR #793 (by @ggarber) with code updated to current v3 and addresses feedback. - All `XxxxConsumer` classes drop empty RTP packets. - `RtpStreamRecv` no longer considers empty RTP packets for counter increase and stream activation. - A substancial change with original PR is that `RtpStreamRecv` accepts those empty packets (otherwise we sould generate NACKs), it's just that those don't account anymore for counter increase and stream activation.
|
@ggarber can you review please? |
jmillan
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
XxxxConsumerclasses drop empty RTP packets.RtpStreamRecvno longer considers empty RTP packets for counter increase and stream activation.RtpStreamRecvaccepts those empty packets (otherwise we would generate invalid NACKs), it's just that those don't account anymore for counter increase and stream activation.