-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix strange rtp header padding #1075
Conversation
Why have you closed this PR @buptlsp? |
I have mentioned this issue for more than 2 weeks, but no one has replied to me. Maybe you guys don't think it's important, but in reality it affects our company a lot money per day. So I had to change it privately. if you guys merge again, I need extra time to fix conflict. I probably don't have enough confidence that you guys will think this is right. after all I've only been studying webrtc and c++ for a few months. |
I solved the last problem with #1022. but it's too complicated to create a pr, I have change a lot of places in private. mybe I should close the issue first? |
Please have some patience. This project is maintained mostly out of working hours. Meaning we cannot always just leave everything and review the PRs as they come. |
Closing the PR because there has been no response is not the way to go. You can kindly ask for feedback if you find you didn't get response in a reasonable time period though. |
Also, in the meantime you can be the one telling us:
Reviewing a PR that you've already tested and with which you have some confidence also helps the reviewing process. |
Well, I'll be more patient next time. I actually found some other issues, and I'll submit pr when I've confirmed them. This pr is in grey testing. I have wrote the problems I found in the review. I'll resubmit when I have done my testing. |
Literally we have spent a week off due to work and we are super busy with many things (some of them indeed related to mediasouop). Please, more patient next time ;) |
BTW these kind of changes definitely need fuzzer testing (see |
refer to #1073